-
-
Notifications
You must be signed in to change notification settings - Fork 1
Add types #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types #1
Conversation
/cc @Rokt33r any ideas around how to work around |
@ChristianMurphy https://github.com/sindresorhus/filenamify/blob/master/index.d.ts |
Thanks @Rokt33r that resolved the issue. |
Blockers have been resolved, this is now ready for review. |
@wooorm note that this also includes a couple JS changes suggested by XO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I wanted to release this but
(on Node 13.0.1 and npm 6.13.0). Any thoughts on why this is happening? |
I've run into this before. |
alright, released! |
This currently has two major blockers
void
Once those are resolved, this will need: